[PATCH] D106156: AArch64/GlobalISel: Cleanup unnecessary size checks in call lowering

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 01:44:35 PDT 2021


tmatheson accepted this revision.
tmatheson added a comment.
This revision is now accepted and ready to land.

There is more explanation in fa0b93b5a0866aad3ce517daab6cd91cc67823ad <https://reviews.llvm.org/rGfa0b93b5a0866aad3ce517daab6cd91cc67823ad>, is that commit also the fix that made these redundant? If so LGTM.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:171
     if (VA.getValVT() == MVT::i8 || VA.getValVT() == MVT::i16)
       std::swap(ValTy, LocTy);
 
----------------
The only use of `ValTy` so could be inlined here and below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106156/new/

https://reviews.llvm.org/D106156



More information about the llvm-commits mailing list