[PATCH] D105919: [AMDGPU] Mark all relevant VOP1 instructions rematerializable

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 17:13:31 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP1Instructions.td:361
 
+let isReMaterializable = 1 in {
 let SubtargetPredicate = isGFX6GFX7 in {
----------------
rampitec wrote:
> arsenm wrote:
> > I think we need a nofpexcept flag check for most of these FP ops
> Do we realy raise anything? I suppose at maximum we will get SNaN, but that can be remated. On practice have you seen a signaling scenario anywhere?
It's not enabled anywhere but the hardware does support it. You just need to check MI::mayRaiseFPException


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105919/new/

https://reviews.llvm.org/D105919



More information about the llvm-commits mailing list