[PATCH] D105836: [AMDGPU] Add TII::isAmbientPhysRegUse() to allow VOP rematerilization

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 06:12:11 PDT 2021


foad added a comment.

Typo in summary "rematerialization".



================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:116
 
     // We can't remat physreg uses, unless it is a constant.
     if (Register::isPhysicalRegister(MO.getReg())) {
----------------
Update this comment?


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:130
+bool SIInstrInfo::isAmbientPhysRegUse(const MachineOperand &MO) const {
+  // And implicit use of exec is not a real register read.
+  return MO.getReg() == AMDGPU::EXEC && MO.isImplicit() &&
----------------
Typo "And".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105836/new/

https://reviews.llvm.org/D105836



More information about the llvm-commits mailing list