[PATCH] D106059: [Polly][Isl] Stop generating isl::union_{set,map} from isl::space. NFC

Sun Jul 18 20:02:16 PDT 2021

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: polly/lib/External/isl/include/isl/isl-noexceptions.h:8

+// clang-format off
+
----------------
patacca wrote:
> Meinersbur wrote:
> > When running `ninja polly-update-format` this file should have been ignored. Are you calling `clang-format` manually?
> > 
> > In any case, adding this annotation by the generator is fine.
> I added this annotation to remove the lint errors that are added automatically by the buildbot and that make harder to read the diff, but I see that the clang-tidy warnings are still present so there might be a different annotation for those (maybe `//clang-tidy off`?)
> I've never had troubles with `ninja polly-update-format` in the sense that it never affected isl-noexceptions.h but in the previous revision (https://reviews.llvm.org/D105691?vs=on&id=357473) there were tons of clang-format warnings on isl-noexceptions.h generated by the buildbot so it might be using a different command than `ninja polly-check-format`
The warning is indeed by clang-tidy (clang-format does not try to open included files).

I don't know a way to switch it off locally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106059/new/

https://reviews.llvm.org/D106059