[PATCH] D106239: [AArch64] Expand the SVE min/max reduction costs to NEON

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

I know you haven't added any reviewers yet, but just saw the patch come by. The original costs for Neon seemed a bit excessive :)
Not sure if you're planning any other changes, but the patch looks fine to me.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1791-1792
+
+  assert(((isa<ScalableVectorType>(Ty) && isa<ScalableVectorType>(CondTy)) ||
+          (!isa<ScalableVectorType>(Ty) && !isa<ScalableVectorType>(CondTy))) &&
+         "Both vector needs to be equally scalable");
----------------
nit: `isa<ScalableVectorType(Ty) == isa<ScalableVectorType>(CondTy)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106239/new/

https://reviews.llvm.org/D106239