[PATCH] D106225: [VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 17 13:02:41 PDT 2021


kaz7 created this revision.
kaz7 added reviewers: simoll, k-ishizaka.
kaz7 added projects: VE, LLVM.
Herald added subscribers: jfb, hiraditya.
kaz7 requested review of this revision.
Herald added a subscriber: llvm-commits.

The implementation of subword atomics does not actually
guarantee the result is zero-extended, which now caused
failures after https://reviews.llvm.org/D101342 was landed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106225

Files:
  llvm/lib/Target/VE/VEISelLowering.h


Index: llvm/lib/Target/VE/VEISelLowering.h
===================================================================
--- llvm/lib/Target/VE/VEISelLowering.h
+++ llvm/lib/Target/VE/VEISelLowering.h
@@ -98,6 +98,9 @@
                                  AtomicOrdering Ord) const override;
   TargetLoweringBase::AtomicExpansionKind
   shouldExpandAtomicRMWInIR(AtomicRMWInst *AI) const override;
+  ISD::NodeType getExtendForAtomicOps() const override {
+    return ISD::ANY_EXTEND;
+  }
 
   /// Custom Lower {
   SDValue LowerOperation(SDValue Op, SelectionDAG &DAG) const override;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106225.359579.patch
Type: text/x-patch
Size: 575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210717/79593c4e/attachment.bin>


More information about the llvm-commits mailing list