[PATCH] D106219: [lld/mac] Change load command order to be more like ld64

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 17 09:11:29 PDT 2021


int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/Writer.cpp:725-726
 
+  if (config->outputType == MH_EXECUTE)
+    in.header->addLoadCommand(make<LCMain>());
+
----------------
:/ seems kind of awkward that this isn't part of the switch statement above. maybe add a comment about why?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106219/new/

https://reviews.llvm.org/D106219



More information about the llvm-commits mailing list