[PATCH] D106059: [Polly][Isl] Stop generating isl::union_{set,map} from isl::space. NFC

Sat Jul 17 05:52:56 PDT 2021

patacca added inline comments.

================
Comment at: polly/lib/External/isl/include/isl/isl-noexceptions.h:8

+// clang-format off
+
----------------
Meinersbur wrote:
> When running `ninja polly-update-format` this file should have been ignored. Are you calling `clang-format` manually?
> 
> In any case, adding this annotation by the generator is fine.
I added this annotation to remove the lint errors that are added automatically by the buildbot and that make harder to read the diff, but I see that the clang-tidy warnings are still present so there might be a different annotation for those (maybe `//clang-tidy off`?)
I've never had troubles with `ninja polly-update-format` in the sense that it never affected isl-noexceptions.h but in the previous revision (https://reviews.llvm.org/D105691?vs=on&id=357473) there were tons of clang-format warnings on isl-noexceptions.h generated by the buildbot so it might be using a different command than `ninja polly-check-format`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106059/new/

https://reviews.llvm.org/D106059