[PATCH] D106189: [InstSimplify] Expose generic interface for replaced operand simplification

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 17 03:23:05 PDT 2021


nikic accepted this revision.
nikic added a comment.

LG



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:6051
 
-  if (auto *C = ConstantFoldInstruction(LI, Q.DL))
-    return C;
+  // Try to mke the lod operand a constant, specifically handle invariant.group
+  // intrinsics.
----------------
make the load


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:6081
+    } else
+      Result = ConstantFoldInstruction(I, Q.DL, Q.TLI);
     break;
----------------
This fallback shouldn't be necessary, ConstantFoldInstruction bails on non-constant operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106189/new/

https://reviews.llvm.org/D106189



More information about the llvm-commits mailing list