[PATCH] D106211: [lld-macho] Reorganize + extend ICF test

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I found icf.s a bit hard to work with as it was not possible to
extend any of the functions `_a` ... `_k` to test new relocation /
referent types without modifying every single one of them. Additionally,
their one-letter names were not descriptive (though the comments
helped).

I've renamed all the functions to reflect the feature they are testing,
and shrunk them so that they contain just enough to test that one
feature.

I've also added tests for non-zero addends (via the
`_abs1a_ref_with_addend` and `_defined_ref_with_addend_1` functions).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106211

Files:
  lld/test/MachO/icf.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106211.359535.patch
Type: text/x-patch
Size: 15723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210717/c2a152ee/attachment.bin>