[PATCH] D106196: [Bazel] Condition Exegesis target-specific sources
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 16 17:53:47 PDT 2021
chandlerc added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:2356-2359
+ ":any_x86": glob([
+ "tools/llvm-exegesis/lib/X86/*.cpp",
+ "tools/llvm-exegesis/lib/X86/*.h",
+ ]),
----------------
I'm confused why we need to condition on whether the *host* is x86?
This may be obvious from the error you're fixing, but I think it would need some kind of comment here. We don't condition the x86 assembler or disassembler on the host architecture...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106196/new/
https://reviews.llvm.org/D106196
More information about the llvm-commits
mailing list