[PATCH] D106200: GlobalISel: Remove some mystery code that clears isReturned

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aemerson, paquette.
Herald added subscribers: hiraditya, rovka.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

I don't understand what this is going for, and haven't found an analog
in DAG code. No tests fail with this removed.


https://reviews.llvm.org/D106200

Files:
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp


Index: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -584,16 +584,6 @@
           Flags.setSplitEnd();
       }
 
-      if (!Assigner.isIncomingArgumentHandler()) {
-        // TODO: Also check if there is a valid extension that preserves the
-        // bits. However currently this call lowering doesn't support non-exact
-        // split parts, so that can't be tested.
-        if (OrigFlags.isReturned() &&
-            (NumParts * NewVT.getSizeInBits() != CurVT.getSizeInBits())) {
-          Flags.setReturned(false);
-        }
-      }
-
       Args[i].Flags.push_back(Flags);
       if (Assigner.assignArg(i, CurTy, NewVT, NewVT, CCValAssign::Full, Args[i],
                              Args[i].Flags[Part], CCInfo)) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106200.359490.patch
Type: text/x-patch
Size: 900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210717/57f90521/attachment.bin>