[PATCH] D106185: [Attributor] Introduce getPotentialCopiesOfStoredValue and use it

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:320
+          dbgs()
+          << "Failed to verify all interfering accesses for underlyibg object: "
+          << *Obj << "\n");
----------------
Nit: typo


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:3085-3090
         const auto &ReachabilityAA = A.getAAFor<AAReachability>(
             *this, IRPosition::function(*ScopeFn), DepClassTy::OPTIONAL);
 
         if (!ReachabilityAA.isAssumedReachable(A, *UserI, *getCtxI()))
           return true;
 
----------------
>From what I can see `checkForAllUses` can now return uses from different functions.
I am worried about some code not handling this case correctly.

For example, do you think this piece of code can cause a problem ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106185/new/

https://reviews.llvm.org/D106185