[PATCH] D106143: [CMake][TSAN] Add build dependency against libcxx

[Adrian Vogelsgesang via Phabricator via llvm-commits]

avogelsgesang added inline comments.


================
Comment at: compiler-rt/lib/tsan/CMakeLists.txt:117
 
+# TSAN uses headers provided by libcxx (errno.h, stdio.h, ...).
+if (TARGET cxx-headers OR HAVE_LIBCXX)
----------------
phosek wrote:
> Headers like `errno.h` or `stdio.h` are provided by libc, not libc++, do you know which libc++ headers are needed by TSan?
my understanding is that the build included `errno.h` from libc++ (https://github.com/llvm/llvm-project/blob/main/libcxx/include/errno.h)

```
In file included from /Volumes/build/tc/473843e25ae443f4/release/src/clang-osx10.11-x86_64-release-master_avogelsgesang-llvm12.12.0.1.c2458596.r74f7019d/compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cpp:23:
/Volumes/build/tc/473843e25ae443f4/release/src/clang-osx10.11-x86_64-release-master_avogelsgesang-llvm12.12.0.1.c2458596.r74f7019d/build/stage1_build/./bin/../include/c++/v1/errno.h:25:10: fatal error: '__config' file not found
#include <__config>
         ^~~~~~~~~~
```

Not sure if that is intentional, or if something is going wrong in a more fundamental way here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106143/new/

https://reviews.llvm.org/D106143