[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 14:12:29 PDT 2021


rjmccall added a comment.

IIUC, we sometimes turn `-retain` message sends into calls to `objc_retain` and so on.  Outside of ARC (the only time they're valid), these calls don't have the semantics of guaranteeing to return their self argument.  So I think this change is only fine if we're not applying it when doing that non-ARC transformation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105671/new/

https://reviews.llvm.org/D105671



More information about the llvm-commits mailing list