[PATCH] D106183: [GlobalISel] Fix non-pow-2 legalization of s56 stores.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 13:18:09 PDT 2021


aemerson created this revision.
aemerson added reviewers: paquette, arsenm.
aemerson added a project: LLVM.
Herald added subscribers: hiraditya, rovka.
aemerson requested review of this revision.
Herald added a subscriber: wdng.

s56 stores are broken down into s32 + s24 stores. During this step both of those new stores use an anyextended s64 value, resulting in truncating stores. With s56, the s24 requires another lower step to make it legal, and we were crashing because we didn't expect non-pow-2 stores to also be truncating as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106183

Files:
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-non-pow2-load-store.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106183.359427.patch
Type: text/x-patch
Size: 5852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210716/ca361c71/attachment.bin>


More information about the llvm-commits mailing list