[PATCH] D106175: [Bazel] Use bazel_skylib paths for paths munging

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 12:11:11 PDT 2021


jpienaar accepted this revision.
jpienaar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: utils/bazel/llvm_configs/BUILD.bazel:5
 
-# We perform diff testing here to avoid any in-tree BUILD files depending on
-# bazel_sklyib. These diff tests ensure that the current Bazel configuration
-# does not drift from the configuration in the .cmake files, since we don't
-# alway use them directly (and even if we did we wouldn't necessarily pick up
-# changes there). These are literal change-detector tests.
+# These diff tests ensure that the current Bazel configurationdoes not drift
+# from the configuration in the .cmake files, since we don't alway use them
----------------
missing space


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106175/new/

https://reviews.llvm.org/D106175



More information about the llvm-commits mailing list