[PATCH] D102673: [ConstantFolding] Fold constrained arithmetic intrinsics

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added a comment.

Thanks!



================
Comment at: llvm/test/Transforms/InstSimplify/constfold-constrained.ll:1
 ; RUN: opt < %s -instsimplify -S | FileCheck %s
 
----------------
spatel wrote:
> If there's not too much noise, I recommend using utils/update_test_checks.py to auto-generate the FileCheck lines in this file - it should eliminate typos and make it easier to update the file with new tests. 
> 
> So (1) add new tests, (2) auto-generate the baseline CHECKs for all tests, (3) apply this patch and re-run the script, so we just have the test diffs.
(1) and (2) are implemented in https://reviews.llvm.org/rGa0b4f424f564


================
Comment at: llvm/test/Transforms/InstSimplify/fdiv-strictfp.ll:27
 ;
-  %f = call float @llvm.experimental.constrained.fdiv.f32(float 3.0, float 2.0, metadata !"round.tonearest", metadata !"fpexcept.ignore") #0
   ret float %f
----------------
spatel wrote:
> Fix this test to not be misleading as a preliminary/NFC commit?
This typo is fixed in https://reviews.llvm.org/rG39a36999f9b4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102673/new/

https://reviews.llvm.org/D102673