[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type

Fri Jul 16 10:31:56 PDT 2021

fitzgen added a comment.

In D105519#2883725 <https://reviews.llvm.org/D105519#2883725>, @sbc100 wrote:

> In D105519#2881482 <https://reviews.llvm.org/D105519#2881482>, @fitzgen wrote:
>
>> Do you have any idea what is up with https://reviews.llvm.org/harbormaster/unit/view/870129/ ? Locally the test passes just fine, and the types certainly look correct to me. It almost looks like whatever version of llvm-mc running in CI doesn't understand ref types properly? Pretty confused here.
>
> @aardappel just added the type checker vary recently (https://reviews.llvm.org/D104945).   So maybe you need to update your local branch?

Ah yes, I think this is it. That patch mentions that `.globaltype` etc must come *before* the entity now, and I believe that is what is going wrong in this test case. Will update the patch in one sec.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105519/new/

https://reviews.llvm.org/D105519