[PATCH] D105641: [lld-macho] Have ICF operate on all sections at once

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM

My one concern is that we now have to set `isec->parent` in a whole bunch of places (vs. the previous centralized setup), and that feels easy to forget if we need it in more spots in the future. I imagine things would blow up pretty loudly if it were forgotten though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105641/new/

https://reviews.llvm.org/D105641