[PATCH] D105703: [hwasan] Use stack safety analysis.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 09:55:27 PDT 2021


fmayer added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407
   bool Recover;
+  bool DisableOptimization;
 };
----------------
fmayer wrote:
> eugenis wrote:
> > No need to pass this down, just look at OptimizeNone function attribute.
> Interesting, the Aarch64StackTagging code does pass this down, do you know why?
Also we really should be using this at least in the getAnalysisUsage, which Vitaly's change made unconditional. Correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703



More information about the llvm-commits mailing list