[PATCH] D106114: [Bazel] Delete deprecated gentbl rule

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 08:18:39 PDT 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG219c729f5ea8: [Bazel] Delete deprecated gentbl rule (authored by GMNGeoffrey).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106114/new/

https://reviews.llvm.org/D106114

Files:
  utils/bazel/llvm-project-overlay/mlir/tblgen.bzl


Index: utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
+++ utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
@@ -436,45 +436,3 @@
         textual_hdrs = [":" + filegroup_name],
         **kwargs
     )
-
-def gentbl(
-        name,
-        tblgen,
-        td_file,
-        tbl_outs,
-        td_srcs = [],
-        td_includes = [],
-        includes = [],
-        td_relative_includes = [],
-        deps = [],
-        test = False,
-        **kwargs):
-    """Deprecated version of gentbl_cc_library.
-
-    Accepts tbl_outs as list of pairs with the first element of the pair being
-    a whitespace-separated string of options rather than a list of options.
-    """
-
-    split_opts = []
-    for (opts_string, out) in tbl_outs:
-        opts = opts_string.split(" ") if opts_string else []
-
-        # Filter out empty options
-        opts = [opt for opt in opts if opt]
-
-        split_opts.append((opts, out))
-
-    gentbl_cc_library(
-        name = name,
-        tblgen = tblgen,
-        td_file = td_file,
-        tbl_outs = split_opts,
-        td_srcs = td_srcs,
-        td_includes = td_includes,
-        includes = includes,
-        td_relative_includes = td_relative_includes,
-        deps = deps,
-        test = test,
-        deprecation = "generated by gentbl; use gentbl_cc_library or gentbl_filegroup instead",
-        **kwargs
-    )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106114.359331.patch
Type: text/x-patch
Size: 1497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210716/8ffbcd9f/attachment-0001.bin>


More information about the llvm-commits mailing list