[PATCH] D106042: [AMDGPU] Ignore KILLs when forming clauses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMCInstLower.cpp:300
+      if (isVerbose())
+        OutStreamer->emitRawComment(" meta instruction");
+      return;
----------------
sebastian-ne wrote:
> arsenm wrote:
> > I don't see a reason to emit a comment for these. Kills for example already have a comment for them
> The problem is that the AsmPrinter only handles top-level instructions, but not instructions inside bundles.
> So, without the code here, printing a bundle containing a KILL will crash because KILL and others are unhandled in `AMDGPUInstPrinter::printInstruction`.
We shouldn't be bundling these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106042/new/

https://reviews.llvm.org/D106042