[PATCH] D105576: [AArch64][SME] Add system registers and related instructions

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked an inline comment as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1379
+  let ParserMethod = "tryParseSVCR";
+  let DiagnosticType = "Invalid" # Name;
+}
----------------
david-arm wrote:
> nit: Maybe simpler to just write "InvalidSVCR" here, since you've explicitly written SVCR in the ParserMethod too?
> nit: Maybe simpler to just write "InvalidSVCR" here, since you've explicitly written SVCR in the ParserMethod too?

`# Name` for diagnostic type is consistent with the other operands so I've kept it as it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105576/new/

https://reviews.llvm.org/D105576