[PATCH] D105576: [AArch64][SME] Add system registers and related instructions

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1379
+  let ParserMethod = "tryParseSVCR";
+  let DiagnosticType = "Invalid" # Name;
+}
----------------
nit: Maybe simpler to just write "InvalidSVCR" here, since you've explicitly written SVCR in the ParserMethod too?


================
Comment at: llvm/test/MC/AArch64/SME/smstart.s:16
+
+smstart sm
+// CHECK-INST: smstart sm
----------------
Can we have a negative test where the keyword is not sm or za and make sure we do something sensible?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105576/new/

https://reviews.llvm.org/D105576