[PATCH] D106129: [ExecutionEngine] Check for libunwind before calling __register_frame

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 23:33:09 PDT 2021


hvdijk created this revision.
hvdijk added a reviewer: lhames.
Herald added subscribers: hiraditya, mgorny.
hvdijk requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

libgcc and libunwind have different flavours of __register_frame. Both flavours are already correctly handled, except that the code to handle the libunwind flavour is guarded by __APPLE__. This change uses the presence of __unw_add_dynamic_fde in libunwind instead to detect whether libunwind is used, rather than hardcoding it as Apple vs. non-Apple.

      

Fixes PR44074.

      

Thanks to Albert Jin <albert.jin at gmail.com> and Chris Schafmeister <chris.schaf at verizon.net> for identifying the problem.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106129

Files:
  llvm/cmake/config-ix.cmake
  llvm/cmake/unwind.h
  llvm/include/llvm/Config/config.h.cmake
  llvm/lib/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106129.359225.patch
Type: text/x-patch
Size: 4742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210716/7fa965eb/attachment.bin>


More information about the llvm-commits mailing list