[PATCH] D106053: [CodeGen] Remove pending AssertZext AssertSext in promoting FP_TO_INT

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 22:45:18 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30754
       // result is v2i32, we have to manually widen the assert.
       if (PromoteVT == MVT::v2i32)
         Res = DAG.getNode(ISD::CONCAT_VECTORS, dl, MVT::v4i32, Res,
----------------
This only exists because of the code you removed.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30758
 
-      Res = DAG.getNode(!IsSigned ? ISD::AssertZext : ISD::AssertSext, dl,
-                        Res.getValueType(), Res,
-                        DAG.getValueType(VT.getVectorElementType()));
-
       if (PromoteVT == MVT::v2i32)
         Res = DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, MVT::v2i32, Res,
----------------
Same with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106053/new/

https://reviews.llvm.org/D106053



More information about the llvm-commits mailing list