[PATCH] D106128: [lld-macho] Use immediate encodings for bind opcodes
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 15 22:38:56 PDT 2021
int3 added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:368-369
+ if ((p->opcode == BIND_OPCODE_DO_BIND_ADD_ADDR_ULEB)
+ && (p->data < (15*sizeof(uint64_t)))
+ && ((p->data % sizeof(uint64_t)) == 0)) {
+ p->opcode = BIND_OPCODE_DO_BIND_ADD_ADDR_IMM_SCALED;
----------------
can we have a comment explaining how `BIND_OPCODE_DO_BIND_ADD_ADDR_IMM_SCALED` works, and where the 15 and `sizeof(uint64_t)` is coming from?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106128/new/
https://reviews.llvm.org/D106128
More information about the llvm-commits
mailing list