[PATCH] D103935: Add Twine support for std::string_view.

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D103935#2881938 <https://reviews.llvm.org/D103935#2881938>, @saugustine wrote:

> Reverting this patch might help in the instant case, but the odds of something similar happening, where the data structure is different across different versions of the standard is very hard to guarantee. And also hard to test for.

When things are hard to test for, we usually rely on vendors to find and report problems during qualification/deployment (like @tstellar did) and then revert/refine/fix the patch that broke them.

Not sure why you see it as likely that a data structure would vary across different versions of the standard. Seems to me that'd only happen when someone has code (like this patch) that explicitly asks for it, assuming your toolchain is ABI compatible between standards versions, like clang and libc++ are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103935/new/

https://reviews.llvm.org/D103935