[PATCH] D103557: [WebAssembly] Generate R_FUNCTION_OFFSET relocs in debuginfo sections

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 18:10:43 PDT 2021


dschuff added a comment.
Herald added a subscriber: ormris.

This is now almost ready, just a couple of issues. Primarily, as the comment on line 510 of WasmObjectWriter.cpp suggests, I don't fully understand how the existing codepath (which uses the section symbol) works. I'm not sure if I should try to understand that more or not. And secondly I figured out a way to test the new behavior (but not the existing one) with a .s file, so I'm not sure whether we should keep the .ll test or not (it would catch any changes in how the dwarf code generates this MC, but I'm not sure we care about that, if the MC code is correct).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103557/new/

https://reviews.llvm.org/D103557



More information about the llvm-commits mailing list