[PATCH] D103770: Injection of kernel features into the LLVM IR during the OpenMP transform stage

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Good feature, but using an array for this looks likely to be error prone.  Do we need to iterate over it somewhere? Order of fields seems likely to end up repeated in a few places.

I think I'd prefer N distinct scalars with names like multiply_kernel.KernelFeature.MaxLoopDepth. Might make the test cases more legible too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103770/new/

https://reviews.llvm.org/D103770