[PATCH] D106094: [ObjCARC] Use objc_msgSend instead of llvm.objc.msgSend in tests

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 13:10:16 PDT 2021


nikic created this revision.
nikic added reviewers: ahatanak, pete, dexonsmith, aeubanks.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D55348 <https://reviews.llvm.org/D55348> replaces `@objc_msgSend` with `@llvm.objc.msgSend` in tests together with many other objc intrinsics. However, this is not a recognized intrinsic (https://llvm.org/docs/LangRef.html#objective-c-arc-runtime-intrinsics) and does not receive special treatment by LLVM. It's likely that uses of this function were renamed by accident.

This came up in D106013 <https://reviews.llvm.org/D106013>, because the address of `@llvm.objs.msgSend` is taken, something which is normally not legal for intrinsics.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106094

Files:
  llvm/test/Transforms/ObjCARC/allocas.ll
  llvm/test/Transforms/ObjCARC/basic.ll
  llvm/test/Transforms/ObjCARC/contract-testcases.ll
  llvm/test/Transforms/ObjCARC/ensure-that-exception-unwind-path-is-visited.ll
  llvm/test/Transforms/ObjCARC/invoke-2.ll
  llvm/test/Transforms/ObjCARC/invoke.ll
  llvm/test/Transforms/ObjCARC/move-and-form-retain-autorelease.ll
  llvm/test/Transforms/ObjCARC/move-and-merge-autorelease.ll
  llvm/test/Transforms/ObjCARC/nested.ll
  llvm/test/Transforms/ObjCARC/path-overflow.ll
  llvm/test/Transforms/ObjCARC/retain-not-declared.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106094.359100.patch
Type: text/x-patch
Size: 95086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210715/78679358/attachment.bin>


More information about the llvm-commits mailing list