[PATCH] D106091: [PowerPC] Improve error message on MASSV pass
Masoud Ataei via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 15 12:51:50 PDT 2021
masoud.ataei created this revision.
masoud.ataei added reviewers: bmahjour, Whitney, etiotto.
masoud.ataei added projects: LLVM, PowerPC.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
masoud.ataei requested review of this revision.
Herald added a subscriber: llvm-commits.
Problem:
If user add `-mno-altivec` along with `-mllvm -vector-library=MASSV` regardless of compiling P8 <https://reviews.llvm.org/P8> or P9 <https://reviews.llvm.org/P9> (or other targets), they will get confusing message.
Solution:
Updated the error message to mention vectorization is needed be enable when using MASSV pass.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D106091
Files:
llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp
Index: llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp
+++ llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp
@@ -82,8 +82,9 @@
if (Subtarget->hasP8Vector())
return "P8";
- report_fatal_error("Unsupported Subtarget: MASSV is supported only on "
- "Power8 and Power9 subtargets.");
+ report_fatal_error(
+ "-vector-library=MASSV option is supported only on Power8 and Power9 "
+ "subtargets when vectorization is not disabled.");
}
/// Creates PowerPC subtarget-specific name corresponding to the specified
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106091.359094.patch
Type: text/x-patch
Size: 672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210715/3ae588ad/attachment.bin>
More information about the llvm-commits
mailing list