[PATCH] D105703: [hwasan] Use stack safety analysis.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1
+// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY
+// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=false -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=NOSAFETY
----------------
You can't use %clang in LLVM tests. There may be no clang. Use opt to invoke the hwasan pass in isolation, see the tests under test/Instrumentation/HWAddressSanitizer/.

The reason I did not say anything about the tests was because only in clang we can test this thing end-to-end.
Perhaps an LLVM test for instrumentation + a clang test for the passmanager (use -fdebug-pass-manager and -mllvm -debug-pass=Structure for new/old).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703