[PATCH] D106077: [llvm-mca] Store extra information about the driver flags used for the simulation

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

A couple of minor nits. Otherwise it LGTM.



================
Comment at: llvm/tools/llvm-mca/PipelinePrinter.cpp:55-56
+  const MCSchedModel &SM = STI.getSchedModel();
+  if (!SM.isOutOfOrder())
+    return SimParameters;
+  if (!PO.AssumeNoAlias)
----------------
Please move this early exit before the check at line 52. We don't care about printing the register-file-size if this is an in-order processor (as we don't simulate register renaming).

Also, add an empty line after it to make the code slightly more readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106077/new/

https://reviews.llvm.org/D106077