[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

Thu Jul 15 11:59:43 PDT 2021

quinnp added inline comments.

================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1
+// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \
+// RUN:   -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8
----------------
nemanjai wrote:
> Oh, I believe you're missing `REQUIRES: powerpc-registered-target` in this test case (please look at the requirements in the other builtins tests).
I don't think I need `REQUIRES: powerpc-registered-target`, I am copying `clang/test/CodeGen/builtins-ppc-xlcompat-pwr9.c` which was committed here https://reviews.llvm.org/D102875#change-CGl81jJwEOZy. Although I may be wrong.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105834/new/

https://reviews.llvm.org/D105834