[PATCH] D106013: [Verifier] Require same signature for intrinsic calls

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D106013#2880590 <https://reviews.llvm.org/D106013#2880590>, @aeubanks wrote:

> `isIntrinsic()` looks like it's equivalent to `getName().startswith("llvm.")`.

Ah right. Apparently the relevant distinction is isIntrinsic() vs getIntrinsicID(). The former just checks for `llvm.`, while the latter requires a registered intrinsic. The `hasAddressTaken()` check is currently only applied to the `getIntrinsicID()` case.

> Is it expected that we can take the address of not-registered intrinsics? That seems wrong. I'd say we should disallow that, making it an easy decision to keep what we have and fix the test.

I'm inclined to agree. I'll give it a try.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106013/new/

https://reviews.llvm.org/D106013