[PATCH] D105751: GlobalISel: Introduce GenericMachineInstr classes and derivatives for idiomatic LLVM RTTI.

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I think this looks fine at this point. Added a couple nits but that's about it.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:701
   // then we can narrow the load width when we combine to a G_SEXTLOAD.
-  auto &MMO = **LoadDef->memoperands_begin();
   // Don't do this for non-simple loads.
+  if (!LoadDef->isSimple())
----------------
This comment seems redundant now.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:702
   // Don't do this for non-simple loads.
-  if (MMO.isAtomic() || MMO.isVolatile())
+  if (!LoadDef->isSimple())
     return false;
----------------
Now that we don't need to pull out MMO explicitly, I think this can be folded into the previous `if`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105751/new/

https://reviews.llvm.org/D105751