[PATCH] D106037: [llvm-readobj] Remove one-dash long options

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 10:28:57 PDT 2021


MaskRay updated this revision to Diff 359042.
MaskRay edited the summary of this revision.
MaskRay added a comment.

address comment

the doc has recommended `--` since D63719 <https://reviews.llvm.org/D63719>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106037/new/

https://reviews.llvm.org/D106037

Files:
  llvm/tools/llvm-readobj/Opts.td


Index: llvm/tools/llvm-readobj/Opts.td
===================================================================
--- llvm/tools/llvm-readobj/Opts.td
+++ llvm/tools/llvm-readobj/Opts.td
@@ -1,17 +1,16 @@
 include "llvm/Option/OptParser.td"
 
 class F<string letter, string help> : Flag<["-"], letter>, HelpText<help>;
-class FF<string name, string help> : Flag<["--", "-"], name>, HelpText<help>;
+class FF<string name, string help> : Flag<["--"], name>, HelpText<help>;
 
 multiclass BB<string name, string help1, string help2> {
-  def NAME: Flag<["--", "-"], name>, HelpText<help1>;
-  def no_ # NAME: Flag<["--", "-"], "no-" # name>, HelpText<help2>;
+  def NAME: Flag<["--"], name>, HelpText<help1>;
+  def no_ # NAME: Flag<["--"], "no-" # name>, HelpText<help2>;
 }
 
 multiclass Eq<string name, string help> {
-  def NAME #_EQ : Joined<["--", "-"], name #"=">,
-                  HelpText<help>;
-  def : Separate<["--", "-"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
+  def NAME #_EQ : Joined<["--"], name #"=">, HelpText<help>;
+  def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
 }
 
 def addrsig : FF<"addrsig", "Display address-significance table">;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106037.359042.patch
Type: text/x-patch
Size: 1168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210715/116f9e67/attachment.bin>


More information about the llvm-commits mailing list