[PATCH] D105577: [AArch64][SME] Add SVE2 instructions added in SME

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 10:24:35 PDT 2021


kmclaughlin added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME/dup-diagnostics.s:37
+// CHECK-NEXT: dup  p0.d, p0/z, p0.d[w12, #2]
+// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
----------------
Can you add some invalid predicate tests for the dup & revd instructions too, e.g. `p8/z`, `p0/m`?


================
Comment at: llvm/test/MC/AArch64/SME/dup.s:121
+// CHECK-ERROR: instruction requires: sme
+// CHECK-UNKNOWN: ef 7d e3 25 <unknown>
----------------
Do we need tests with movprfx for the dup instruction also?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105577/new/

https://reviews.llvm.org/D105577



More information about the llvm-commits mailing list