[PATCH] D106077: [llvm-mca] Store extra information about the driver flags used for the simulation

[Marcos Horro via Phabricator via llvm-commits]

markoshorro added inline comments.


================
Comment at: llvm/test/tools/llvm-mca/JSON/X86/views.s:163-174
+# CHECK-NEXT:   "SimulationParameters": {
+# CHECK-NEXT:     "-decoder-throughput": 0,
+# CHECK-NEXT:     "-dispatch": 0,
+# CHECK-NEXT:     "-lqueue": 0,
+# CHECK-NEXT:     "-march": "x86_64",
+# CHECK-NEXT:     "-mcpu": "haswell",
+# CHECK-NEXT:     "-micro-op-queue-size": 0,
----------------
andreadb wrote:
> I think that we should just ignore flags like `-dispatch`, `-squeue`, `-lqueue`, etc. if their value hasn't been changed by the user. I suggest to only report flags whose value doesn't correspond to their default.
> 
> The only exceptions would be mcpu/march/mtriple which (at least in my opinion) should always be present for completeness.
Ok, I agree! Do you think this information should be printed as well in the classic report?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106077/new/

https://reviews.llvm.org/D106077