[PATCH] D103935: Add Twine support for std::string_view.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 09:45:44 PDT 2021


saugustine added a comment.

I'm not sure removing the ifdef guards around the enum value is better.

That would also mean moving the #ifdef guards in all the switch statements so the enum value would be present but unhandled by doing nothing (or asserting or similar) which seems pretty wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103935/new/

https://reviews.llvm.org/D103935



More information about the llvm-commits mailing list