[PATCH] D106033: Folding threadLimit and numThreads when single value in kernels

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 09:33:17 PDT 2021


JonChesterfield added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3614
 
+  /// Fold __kmpc_get_hardware_num_blocks into a constant if possible.
+  /// The value is an attribute in the kernel
----------------
I haven't read through this part, but if we can only fold it to a constant sometimes, we shouldn't mark the calls that survive noinline, as that'll be expensive for the cases that this pass misses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106033/new/

https://reviews.llvm.org/D106033



More information about the llvm-commits mailing list