[PATCH] D105822: [docs] More CMAKE variable documentation

[Shivam Gupta via Phabricator via llvm-commits]

xgupta added inline comments.


================
Comment at: llvm/docs/CMake.rst:211
+
+.. _Frequently Used LLVM-specific variables:
+
----------------
aaron.ballman wrote:
> xgupta wrote:
> > I think similar documentation is available on getting started page - https://llvm.org/docs/GettingStarted.html#getting-the-source-code-and-building-llvm, https://llvm.org/docs/GettingStarted.html#local-llvm-configuration and  https://llvm.org/docs/GettingStarted.html#common-problems. 
> > 
> > And again the same variables are listed on the same cmake.rst page below so again a duplication.
> Good catch on the repeated documentation in places. As a follow-up, it might be nice to have all of those places point to this documentation so we have everything funneled into one place. But I don't think that needs to happen as part of this patch.
Sounds good to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105822/new/

https://reviews.llvm.org/D105822