[PATCH] D105822: [docs] More CMAKE variable documentation

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for the improvements!



================
Comment at: llvm/docs/CMake.rst:195-198
+  most platforms. Be aware that Release and
+  RelWithDebInfo use different optimization levels on most
+  platforms, and that the default value of ``LLVM_ENABLE_ASSERTIONS``
+  is affected.
----------------
You can re-flow these lines to 80 col.


================
Comment at: llvm/docs/CMake.rst:211
+
+.. _Frequently Used LLVM-specific variables:
+
----------------
xgupta wrote:
> I think similar documentation is available on getting started page - https://llvm.org/docs/GettingStarted.html#getting-the-source-code-and-building-llvm, https://llvm.org/docs/GettingStarted.html#local-llvm-configuration and  https://llvm.org/docs/GettingStarted.html#common-problems. 
> 
> And again the same variables are listed on the same cmake.rst page below so again a duplication.
Good catch on the repeated documentation in places. As a follow-up, it might be nice to have all of those places point to this documentation so we have everything funneled into one place. But I don't think that needs to happen as part of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105822/new/

https://reviews.llvm.org/D105822