[PATCH] D105822: [docs] More CMAKE variable documentation

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 06:06:18 PDT 2021


urnathan marked 3 inline comments as done.
urnathan added inline comments.


================
Comment at: llvm/docs/CMake.rst:225
+Frequently Used LLVM-specific variables
+-----------------------
+
----------------
aaron.ballman wrote:
> urnathan wrote:
> > aaron.ballman wrote:
> > > Underlines are off here, so sphinx will complain about this.
> > I don't know what that means -- I tried to figure out how to sphinx it, but failed.  I (attempted to) match the formatting of other section headers.
> The count of underlines needs to match the count of characters on the line. I made a suggested edit to show what I mean.
ah, I see, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105822/new/

https://reviews.llvm.org/D105822



More information about the llvm-commits mailing list