[PATCH] D106052: [flang][driver] Randomise the names of the temporary unparsed files

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/tools/f18/flang.in:331
+  # invocation. Otherwise we can't use this script in parallel.
+  RANDOM=$(date +%N | cut -b4-9)
+  local -r unparsed_file_base="flang_unparsed_source_file_$RANDOM"
----------------
DavidSpickett wrote:
> Wouldn't date/time have a small chance to collide?
> 
> Would something like `/proc/sys/kernel/random/uuid` be better to guarantee that each one is unique?
> Wouldn't date/time have a small chance to collide?

I'm also slightly concerned, but `%N` gives you nanoseconds and I'd hope that that's enough to get rando results.

> Would something like `/proc/sys/kernel/random/uuid` be better to guarantee that each one is unique?

I like your suggestion! Are we confident that it's going to be present on every system that this script might be run on? I think that it would be OK to limit it to Linux, but I would need to check with @sscalpone (he is likely to use this script a lot).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106052/new/

https://reviews.llvm.org/D106052