[PATCH] D105574: [AArch64][SME] Add mova instructions

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:88
+
+defm INSERT_MXIPZ : sme_vector_to_tile<"mova">;
+defm EXTRACT_ZPMXI : sme_tile_to_vector<"mova">;
----------------
nit: align


================
Comment at: llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp:314
+    case AArch64::EXTRACT_ZPMXI_V_B:
+      MI.insert(MI.begin()+2, MCOperand::createReg(AArch64::ZAB0));
+      break;
----------------
Can you add a comment here to explain the reason for //+2//?



================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:621
+    let Inst{8-6} = ZAn;
+    let Inst{5} = imm;
+  }
----------------
nit:align


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105574/new/

https://reviews.llvm.org/D105574