[PATCH] D106045: [LoopFlatten] Use Loop to identify loop induction phi. NFC
Rosie Sumpter via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 15 02:25:30 PDT 2021
RosieSumpter updated this revision to Diff 358871.
RosieSumpter marked 2 inline comments as done.
RosieSumpter added a comment.
- Removed setting inductionPHI to nullptr
- Removed else
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106045/new/
https://reviews.llvm.org/D106045
Files:
llvm/lib/Transforms/Scalar/LoopFlatten.cpp
Index: llvm/lib/Transforms/Scalar/LoopFlatten.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopFlatten.cpp
+++ llvm/lib/Transforms/Scalar/LoopFlatten.cpp
@@ -124,19 +124,12 @@
// Find the induction PHI. If there is no induction PHI, we can't do the
// transformation. TODO: could other variables trigger this? Do we have to
// search for the best one?
- InductionPHI = nullptr;
- for (PHINode &PHI : L->getHeader()->phis()) {
- InductionDescriptor ID;
- if (InductionDescriptor::isInductionPHI(&PHI, L, SE, ID)) {
- InductionPHI = Φ
- LLVM_DEBUG(dbgs() << "Found induction PHI: "; InductionPHI->dump());
- break;
- }
- }
+ InductionPHI = L->getInductionVariable(*SE);
if (!InductionPHI) {
LLVM_DEBUG(dbgs() << "Could not find induction PHI\n");
return false;
}
+ LLVM_DEBUG(dbgs() << "Found induction PHI: "; InductionPHI->dump());
auto IsValidPredicate = [&](ICmpInst::Predicate Pred) {
if (ContinueOnTrue)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106045.358871.patch
Type: text/x-patch
Size: 1034 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210715/b3d75bd1/attachment.bin>
More information about the llvm-commits
mailing list