[PATCH] D105632: [LV] Use lookThroughAnd with logical reductions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 01:27:13 PDT 2021


david-arm added a comment.

Hi @dmgreen, I think the particular problem you're worried about may not happen. This is because @kmclaughlin's tests also include the flags `-dce -instcombine`, which I think may have eliminated a redundant `and` instruction after the `select` that deals with this. It might be worth @kmclaughlin just creating a test with the mask 0x7f (127) in your example and seeing what the output looks like? The additional flags do make the IR tidier, but sometimes hide the work done by the vectoriser to ensure correctness.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105632/new/

https://reviews.llvm.org/D105632



More information about the llvm-commits mailing list